search

halleck1 / bzreader

Automatically exported from code.google.com/p/bzreader
0 stars 0 forks source link

Right-to-left languages support #7

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Load a wikipedia dump of the Hebrew Wikipedia, or the Arabic one, etc.
2. view any entry at all.

What is the expected output? What do you see instead?

--> See the text flowing left-to-right, when it should flow right-to-left.

What version of the product are you using? On what operating system?
Latest binary as of today: 1.0.7.0, on Windows XP

Please provide any additional information below.
It should be easy to just add a per-dump setting DefaultTextDirection or 
something similar.  I'd love to do it myself, given access.  I'm syncing 
the svn repo to prepare a patch.

Original issue reported on code.google.com by asaf.bartov on 27 Nov 2008 at 12:03

GoogleCodeExporter commented 9 years ago 
My patch is attached.  It's just very basic support -- it adds a menu item for 
selecting RTL (right-to-left) text flow (defaulting to false, of course), and 
any 
page loaded after selecting RTL flow would be shown in RTL and right-aligned by 
default.  The menu item is a toggle.

Still to do: have the current page refresh (i.e. re-run the formatter) after 
changing 
text flow direction.

Your comments very welcome.

FYI, I'm working on this in view of providing the Hebrew Wikipedia project with 
an 
offline tool for their involvement with the One Laptop Per Child project in 
Israel.

Original comment by asaf.bartov on 27 Nov 2008 at 1:48

Attachments:

GoogleCodeExporter commented 9 years ago 
Hi,

Thanks for the patch! I will add it to the SVN when I get back to my main 
computer.
Great that OLPC might benefit from this :-)

Cheers,
Volodymyr

Original comment by halle...@gmail.com on 27 Nov 2008 at 7:37

GoogleCodeExporter commented 9 years ago

Original comment by halle...@gmail.com on 27 Nov 2008 at 7:37

GoogleCodeExporter commented 9 years ago 
I'd like to discuss more changes with you (such as adding features to the 
formatter 
to support more wiki markup), and in general, to join the project.  I can't 
seem to 
find your contact information anywhere on the site, nor any mailing list for 
the 
project where this discussion could take place.  Can you send me your contact 
info?  
I'm reachable at my username (above) at GMail.  Thanks.

Original comment by asaf.bartov on 27 Nov 2008 at 10:28

GoogleCodeExporter commented 9 years ago 
Applied the patch to SVN, the fix will be in 1.0.8.

Thanks!

Original comment by halle...@gmail.com on 29 Nov 2008 at 10:19