search

hallee / eslint-action

✨ ESLint GitHub Action with inline lint annotations for pull requests
MIT License
120 stars 38 forks source link

Allow user to specify project directory #4

Closed dejagersh closed 4 years ago

dejagersh commented 4 years ago

I have several javascript applications nested in my project, each having their own eslint configurations. I would like to be able to specify the directory in which the linting is done.

mskadu commented 4 years ago

Thanks for teaming up here @thejager - I am grateful for your prompt actions. As I've said, this is of interest to me - since all of my projects have node.js projects nested under the main one as sub-folders.

darshkpatel commented 4 years ago

+1 on this, I was planning to fork and add this feature when i came across this PR. I have multiple projects under multiple sub directories , would be helpful to specify directory

dejagersh commented 4 years ago

@hallee can you merge this?

hallee commented 4 years ago

Hi @thejager, thanks for the PR.

https://github.com/hallee/eslint-action/pull/3 also has project directory support along with a couple other features, so I'm going to try to get that PR merged instead.

dejagersh commented 4 years ago

Ah I didn't even see that. Perfect, thanks!

Feel free to close this PR when you see fit.