search

hallee / eslint-action

✨ ESLint GitHub Action with inline lint annotations for pull requests
MIT License
119 stars 38 forks source link

Don't advertise using the master branch as the version #8

Closed ponychicken closed 4 years ago

ponychicken commented 4 years ago

Especially for CI it is a good choice to use a controlled environment. We copied the code from the README file, which contains 

uses: hallee/eslint-action@master

I think it would be better to recomente using a fixed version:

uses: hallee/eslint-action@1.0
darshkpatel commented 4 years ago

+1 using a tested release version is a better idea than relying on a changing master

jeffbyrnes commented 4 years ago

As it turns out, the current HEAD of the master branch is the only pointer that contains any of this repo’s real improvements over the original it forked (gimenete/eslint-action).

But it definitely is not quite working in some cases.

hallee commented 4 years ago

Fixed as of #13, thanks. I'll try to not make breaking changes going forward