search

halleysfifthinc / Peaks.jl

Find peaks (local extrema) of signals
https://halleysfifthinc.github.io/Peaks.jl/
MIT License
75 stars 8 forks source link

Make errors in peakwidths! more friendly #40

Closed KronosTheLate closed 5 months ago

KronosTheLate commented 5 months ago

I encountered one of the errors, and found that it could have been more helpful, and made the changes here.

Related note: would it not be better to add the missing field than to throw an error?

KronosTheLate commented 5 months ago

I had not though about the automagic solution leading to having to choose values for different parameters. That is a very good reason not to do too much. With the added hint, I also feel like there is not that much friction.

Thanks for the quick review!