search

hallvard / plantuml

Embed UML diagrams in files and view them in Eclipse
http://plantuml.sourceforge.net/
212 stars 58 forks source link

1.1.31 does not work after installation #179

Closed uwe83 closed 5 months ago

uwe83 commented 5 months ago

Hi,

thank you for working on PlantUML plugin!

I had filed #177 and still cannot install the latest plugin, also the released version. I provide the log here:

PlantumlFailLog.log

The way I read this is that it is failing because my Eclipse is running Java 17, but Java 18 would be needed for the lib. And then everyhting else fails because it depends on that.

I would have expected that somehow this works by Eclipse magic, e.g. by updating to Java 18 during installation or something like that. Alternatively, it could have warned that this will not work.

uwe83 commented 5 months ago

I found this in my eclipse.ini

-startup plugins/org.eclipse.equinox.launcher_1.6.700.v20240213-1244.jar --launcher.library plugins/org.eclipse.equinox.launcher.win32.win32.x86_64_1.2.900.v20240213-1244 -product org.eclipse.epp.package.dsl.product -showsplash org.eclipse.epp.package.common --launcher.defaultAction openFile --launcher.appendVmargs -vm plugins/org.eclipse.justj.openjdk.hotspot.jre.full.win32.x86_64_17.0.10.v20240120-1143/jre/bin -vmargs -Dorg.eclipse.ecf.provider.filetransfer.excludeContributors=org.eclipse.ecf.provider.filetransfer.httpclientjava -Dosgi.requiredJavaVersion=17 -Dosgi.instance.area.default=@user.home/eclipse-workspace -Dosgi.dataAreaRequiresExplicitInit=true -Dorg.eclipse.swt.graphics.Resource.reportNonDisposed=true -Declipse.e4.inject.javax.warning=false -Dsun.java.command=Eclipse -Xms256m -Xmx2048m -XX:+UseG1GC -XX:+UseStringDeduplication --add-modules=ALL-SYSTEM -Djava.security.manager=allow

travkin79 commented 5 months ago

Hello @uwe83, Thank you very much for reporting this issue. I think, it was not a good idea, to use Java 18 in the PlantUML Eclipse plug-ins development. I'll change that to Java 17, since that's the Java version used by the Eclipse IDE in the target platform. Besides, neither the PlantUML library nor the PlantUML Eclipse plug-ins need Java 18. I'll prepare a new release.

travkin79 commented 5 months ago

Hi @uwe83, I prepared a new 1.1.31.202404161327 release (candidate). It should already be available on the PlantUML update site http://hallvard.github.io/plantuml, but I did not mark it as the latest PlantUML release on GitHub, yet.

Could you please check if this version works for you?

uwe83 commented 5 months ago

Yes, I can confirm it is working for me. Thanks for the quick fix!

travkin79 commented 5 months ago

Fixed by Downgrading to JavaSE-17 (not Java 18) and re-creating the release 1.1.31