search

hallzy / youtube-playlist-search

A Chrome Extension to search Youtube Playlists for Videos
71 stars 7 forks source link

Extension menu doesn't open #10

Open ElmorenohWTF opened 2 years ago

ElmorenohWTF commented 2 years ago

The menu that should open when you left-click on the extension to log in with your Google account and use the extension, simply does not open, when I left-click on it, it just shows this: image

hallzy commented 2 years ago

Not sure what page you are on, but the extension only does something when you are on a playlist page, but also I have absolutely no idea if this extension works on Edge to begin with, which is what it looks like you are using. I know that Google has been screwing around with the ability to authenticate from non Google Chrome browsers for extensions that use Google APIs.

ElmorenohWTF commented 2 years ago

Not sure what page you are on, but the extension only does something when you are on a playlist page, but also I have absolutely no idea if this extension works on Edge to begin with, which is what it looks like you are using. I know that Google has been screwing around with the ability to authenticate from non Google Chrome browsers for extensions that use Google APIs.

I've tried using Chrome and the same thing happens to me

ElmorenohWTF commented 2 years ago

Ok, it's my problem, I got it to work in Chrome. Maybe it would be nice to add something in case you click on the extension on another page than a playlist, so you don't think it doesn't work, as it happened to me. On another note, would it be possible to get this extension to work in Edge Chromium somehow? It only says: “Error: couldn't retrieve YouTube API Auth Token” when I click on the extension being in a playlist and having added my client ID.

hallzy commented 2 years ago

it's probably possible to add something for that case, I'd have to look into it at some point.

I have never used edge before, and so I don't know what kind of settings it has... I know for a while the Brave browser had a setting somewhere called "Allow Google login for extensions" which you had to enable to get this extension to work, so there might be something similar, but it doesn't work in Brave anymore even with that setting set. Google purposefully made a change to their APIs so that (as far as I know) only Google Chrome can use their APIs, and unless that has changed there is absolutely nothing that I can do about it unfortunately. Which also sucks for me, because the only browser I use is Brave, but now I use Chrome when I need to search for something with this extension.

ElmorenohWTF commented 2 years ago

As far as I know, there is no similar option for Edge.

ElmorenohWTF commented 2 years ago

I was researching and apparently Edge does not support getAuthToken, according to this page: https://docs.microsoft.com/en-us/microsoft-edge/extensions-chromium/developer-guide/api-support#additional-considerations-for-supported-apis, they suggest using launchWebAuthFlow instead of getAuthToken, would it be possible to do that for this extension? Maybe with that it would work in other browsers than Chrome but based on Chromium?

hallzy commented 2 years ago

Interesting... I have no idea if it will work, but it would be worth trying. If I have time after work today I'll give it a try.

I'll come back here and let you know what I find.

Thanks for the suggestion :)

ElmorenohWTF commented 2 years ago

Thanks to you for creating this fascinating extension which is so necessary :D

hallzy commented 2 years ago

So, unless I am an idiot (an observation I am not willing to rule out just yet...) launchWebAuthFlow seems more complicated and seems to require a whole separate setup in the dev console... It requires redirect URLs (the purpose for which is a mystery... I have no idea why an extension needs these or even what they are supposed to be) which you can only do if you set it up as a web app instead of a chrome app, which seems weird, and from what some people have said online, it sounds like it may not even send back the token that I need to use the youtube api.

So, it is entirely possible that this also doesn't work.

I tried a few things and nothing so far has worked, so I might try setting up a "web app" in the google dev console and see if I can somehow get it to work despite what others say online.

I also came across a YouTube video and supposedly the launchWebAuthFlow logs you out after an hour or something. idk... I'll need to look at it more.

Why Google can't just make anything simple, I don't know... This shouldn't exactly be rocket surgery 🚀👨‍⚕️