halo-dev / halo

强大易用的开源建站工具。
https://www.halo.run
GNU General Public License v3.0
32.5k stars 9.46k forks source link

fix: resolve issue with secret input saving additional data #6196

Closed ruibaby closed 1 week ago

ruibaby commented 1 week ago

What type of PR is this?

/kind bug /area ui /milestone 2.17.x

What this PR does / why we need it:

修复 Secret Input 保存之后会多出 Secret Form 中数据的问题。

Which issue(s) this PR fixes:

Fixes #6193

Special notes for your reviewer:

测试方式:

  1. 在保存 Secret 的表单选项前,打开一次编辑 Secret 的对话框。
  2. 保存数据,检查内容是否多出了其他数据。

Does this PR introduce a user-facing change?

None
codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 57.02%. Comparing base (bc10336) to head (9d2bfe9). Report is 32 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #6196 +/- ## ============================================ + Coverage 54.51% 57.02% +2.51% - Complexity 3523 3717 +194 ============================================ Files 646 651 +5 Lines 21862 22041 +179 Branches 1528 1542 +14 ============================================ + Hits 11917 12568 +651 + Misses 9328 8866 -462 + Partials 617 607 -10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

f2c-ci-robot[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[ui/OWNERS](https://github.com/halo-dev/halo/blob/main/ui/OWNERS)~~ [JohnNiang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment