halo-dev / halo

强大易用的开源建站工具。
https://www.halo.run
GNU General Public License v3.0
32.5k stars 9.46k forks source link

Rectify role templates about PAT and 2FA endpoints #6201

Closed JohnNiang closed 1 week ago

JohnNiang commented 1 week ago

What type of PR is this?

/kind bug /area core /milestone 2.17.x

What this PR does / why we need it:

In PR https://github.com/halo-dev/halo/pull/6130, I changed the api group of PAT and 2FA endpoints, but I forgot to change the corresponding role templates. So other users except admin will encounter 403 error like https://github.com/halo-dev/halo/issues/6199.

Which issue(s) this PR fixes:

Fixes https://github.com/halo-dev/halo/issues/6199

Does this PR introduce a user-facing change?

None
codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 57.06%. Comparing base (bc10336) to head (a13e6c2). Report is 25 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #6201 +/- ## ============================================ + Coverage 54.51% 57.06% +2.55% - Complexity 3523 3717 +194 ============================================ Files 646 651 +5 Lines 21862 22041 +179 Branches 1528 1542 +14 ============================================ + Hits 11917 12577 +660 + Misses 9328 8858 -470 + Partials 617 606 -11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

f2c-ci-robot[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/halo-dev/halo/blob/main/OWNERS)~~ [guqing,ruibaby] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment