fix: causing API to be pending when plugin startup encounters an error

guqing commented 3 months ago

What type of PR is this?

/kind improvement /area core /area plugin

What this PR does / why we need it:

修复当启动插件遇到 Error 级别的错误时会导致 API 被挂起无法终止的问题

- Throwable
    - Error
    - Exception

see #6192 for more details

Which issue(s) this PR fixes:

Fixes #6192

Does this PR introduce a user-facing change?

修复当启动插件遇到 Error 级别的错误时会导致 API 被挂起无法终止的问题

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 57.04%. Comparing base (bc10336) to head (5c15ce9). Report is 32 commits behind head on main.

Files	Patch %	Lines
...pp/core/extension/reconciler/PluginReconciler.java	33.33%	2 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #6207 +/- ## ============================================ + Coverage 54.51% 57.04% +2.53% - Complexity 3523 3717 +194 ============================================ Files 646 651 +5 Lines 21862 22041 +179 Branches 1528 1542 +14 ============================================ + Hits 11917 12574 +657 + Misses 9328 8860 -468 + Partials 617 607 -10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

f2c-ci-robot[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/halo-dev/halo/blob/main/OWNERS)~~ [JohnNiang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

halo-dev / halo