halo-dev / halo

强大易用的开源建站工具。
https://www.halo.run
GNU General Public License v3.0
32.47k stars 9.45k forks source link

chore: compatibility support for null for sort parameter of listAll #6230

Closed guqing closed 4 days ago

guqing commented 4 days ago

What type of PR is this?

/area core /milestone 2.17.x

What this PR does / why we need it:

由于2.17.0 修改了 listAll 的实现导致出现了不兼容 Sort 参数为 null 的情况,考虑到给开发者适应的时间因此先兼容并给出警告日志

see also #6219

Which issue(s) this PR fixes:

Fixes #6219

Does this PR introduce a user-facing change?

None
codecov[bot] commented 4 days ago

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 57.18%. Comparing base (bc10336) to head (a2782ab). Report is 42 commits behind head on main.

Files Patch % Lines
...alo/app/extension/ReactiveExtensionClientImpl.java 60.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #6230 +/- ## ============================================ + Coverage 54.51% 57.18% +2.67% - Complexity 3523 3719 +196 ============================================ Files 646 647 +1 Lines 21862 21972 +110 Branches 1528 1536 +8 ============================================ + Hits 11917 12565 +648 + Misses 9328 8797 -531 + Partials 617 610 -7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

f2c-ci-robot[bot] commented 4 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/halo-dev/halo/blob/main/OWNERS)~~ [JohnNiang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment