halo-dev / halo

强大易用的开源建站工具。
https://www.halo.run
GNU General Public License v3.0
32.47k stars 9.45k forks source link

chore: cleanup deprecated constructor for base plugin #6243

Closed guqing closed 2 days ago

guqing commented 4 days ago

What type of PR is this?

/kind cleanup /area plugin /milestone 2.17.x

What this PR does / why we need it:

移除 BasePlugin 中已经过时的构造方法

在 2.6.1 版本中将 BasePlugin(PluginWrapper wrapper) 标记为过时并使用 BasePlugin(PluginContext pluginContext) 代替,现在已经过了很多版本,是时候移除它了。

see also #4023

Does this PR introduce a user-facing change?

开发者相关:移除 BasePlugin 中已经过时的构造方法
codecov[bot] commented 4 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 58.06%. Comparing base (bc10336) to head (77583c0). Report is 59 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #6243 +/- ## ============================================ + Coverage 54.51% 58.06% +3.55% - Complexity 3523 3749 +226 ============================================ Files 646 647 +1 Lines 21862 21963 +101 Branches 1528 1536 +8 ============================================ + Hits 11917 12752 +835 + Misses 9328 8594 -734 Partials 617 617 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JohnNiang commented 4 days ago

/milestone 2.18.x

移除改构造函数会造成很多插件无法启动。建议等 Halo 2.17.0 发布之后再合并,并通过各个渠道通知插件开发者我们将正式在 2.18 中移除过时的构造函数。

/hold

f2c-ci-robot[bot] commented 2 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/halo-dev/halo/blob/main/OWNERS)~~ [JohnNiang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment