halo-dev / plugin-sitemap

Halo 2.0 的站点 Sitemap 生成插件
https://halo.run/store/apps/app-QDFMI
GNU General Public License v3.0
6 stars 6 forks source link

Adapt to external URI that might not be a URL #6

Closed JohnNiang closed 1 year ago

JohnNiang commented 1 year ago

The external URI might not be an URL, so it would not work well. See https://github.com/halo-dev/halo/issues/3762 for more.

This PR

BTW, I have tested this plugin on Halo 2.0-2.4.

You could test this plugin manually using plugin-sitemap.zip.

/kind bug

修复 External URL 为“/”时无法访问的问题
JohnNiang commented 1 year ago

/cc @halo-sigs/halo

f2c-ci-robot[bot] commented 1 year ago

@JohnNiang: GitHub didn't allow me to request PR reviews from the following users: halo-sigs/halo.

Note that only halo-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/halo-sigs/plugin-sitemap/pull/6#issuecomment-1511505379): >/cc @halo-sigs/halo Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
JohnNiang commented 1 year ago

/ping @halo-sigs/halo

f2c-ci-robot[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/halo-sigs/plugin-sitemap/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
JohnNiang commented 1 year ago

I'm going to merge this PR manually, because the automatic merge is unavailable currently.