search

halo-sigs / plugin-links

Halo 2.0 的链接管理插件
https://www.halo.run/store/apps/app-hfbQg
GNU General Public License v3.0
30 stars 7 forks source link

fix: link management permission was assigned but still did not have permission #15

Closed guqing closed 1 year ago

guqing commented 1 year ago

What this PR does?

修复分配了友链管理权限仍无权限访问的问题 /kind improvement

/cc @halo-sigs/halo

how to test it?

  1. 在此 PR 构建插件安装
  2. 新建一个角色分配链接查看/管理权限，期望能正确获取到友链分组和友链
修复给角色分配友链管理权限仍无权限访问的问题
f2c-ci-robot[bot] commented 1 year ago

@guqing: GitHub didn't allow me to request PR reviews from the following users: halo-sigs/halo.

Note that only halo-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/halo-sigs/plugin-links/pull/15): >### What this PR does? >修复分配了友链管理权限仍无权限访问的问题 >/kind improvement > >/cc @halo-sigs/halo >### how to test it? >1. 在此 PR 构建插件安装 >2. 新建一个角色分配链接查看/管理权限，期望能正确获取到友链分组和友链 > >```release-note >修复给角色分配友链管理权限仍无权限访问的问题 >``` Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
f2c-ci-robot[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/halo-sigs/plugin-links/blob/main/OWNERS)~~ [JohnNiang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment