halo / LinkLiar

:link: Link-Layer MAC spoofing GUI for macOS
http://halo.github.io/LinkLiar
MIT License
1.23k stars 84 forks source link

update app icon to fit Big Sur #51

Closed M-Makise-Kurisu closed 7 months ago

halo commented 2 years ago

First I thought: the menu bar icon looks good, what do you mean? But then I realized you mean when you put the app in your Dock, right? I never did that so I didn't notice it.

Screen Shot 2021-09-01 at 11 59 25

There is one problem: I'm hesitant to using the menu bar icon as "official app icon", because of the license restriction.

Licensee may not use the Work as part of a logo, trademark or service mark.

Maybe it's time to have a designer create a completely new logo from scratch. What does a MAC address spoofer look like anyway?

Then again the logo is so "simple", maybe iconmonstr is going to make an exception. We could ask the creator Alexander Kahlkopf whether he'd be OK with us using it as app logo, since LinkLiar is an open-source project.

bunkerdesign commented 10 months ago

I've made this so if its okay you can use it

LinkLiar LinkLiar.icns.zip

halo commented 10 months ago

Hi!

This is really nice and also timely, as I'm trying to release a new version of LinkLiar by the end of the year. However, that particular symbol comes from here: https://iconmonstr.com/connection-3-svg/

and it says explicitly, that those icons are not allowed as a "logo": https://iconmonstr.com/license/

As I wrote above in this issue, two ways to go forward:

We could ask the creator Alexander Kahlkopf whether he'd be OK with us using it as app logo, since LinkLiar is an open-source project.

or

Maybe it's time to have a designer create a completely new logo from scratch.

Whichever of the two you prefer :)

halo commented 9 months ago

I'm thinking about switching the menu bar icon to bolt.fill from Apple SF Symbols.

Screenshot 2023-11-21 at 21 33 34

Or do you think the current one is better? The one from Apple maybe looks too much like a battery power symbol.

bunkerdesign commented 8 months ago

Hi! Sorry for late reply. Here's a quick sketch:

chainlightning

The idea is to combine lightning symbol with a traditional 'link' chain symbol. I think it represents the app better than a current one and any of the apple symbol. Also keeps the heritage lightning look.

If you like my idea I will finalise the logo and make all necessary variations

halo commented 8 months ago

I love it!

Thank you for investing the time and energy. This is great!

The format I would need for Xcode would be:

bunkerdesign commented 8 months ago

Hi! Here's the results: https://drive.google.com/drive/folders/1Y0u81ldJJGQobZZAnRI5D9nuZSX6BAEY?usp=share_link

Menubar icons might need fixes so I will be in touch 🙌

bunkerdesign commented 8 months ago

Icon preview:

AppIcon Preview

Also a Figma Link to all assets

halo commented 8 months ago

Sweet! Thank you.

Screenshot 2023-12-07 at 16 28 40


Screenshot 2023-12-07 at 16 28 55

Do you think I should make the menu bar icon configurable?

Or do we start off by using only the "filled" one? The "line" one looks maybe a bit thin compared to the others.

This is where the application icon is presented, in Apple System Settings > General > Login Items

Screenshot 2023-12-07 at 16 43 03
bunkerdesign commented 8 months ago

You are welcome! 🙂 I think the filled one looks better because it has less intricate details and has more contrast, so I would stick to the filled one

halo commented 7 months ago

So, it took a while, but the new icons ended up in the master branch now. I'll have to improve test coverage, get people to test it out and then make an official release, but it's there: https://github.com/halo/LinkLiar/tree/master/LinkLiar/Assets.xcassets

So I'll gratefully close this issue, I'm really pleased with the new icon!