search

halo / macosvpn

:wrench: Create macOS VPNs programmatically (L2TP & Cisco)
Other
442 stars 72 forks source link

command line no use --split error ,want setting "Send all traffic over VPN connection" #43

Closed creaplus closed 4 years ago

creaplus commented 4 years ago

When I created the l2tp VPN, I did not use the "--split" option to make all traffic go through the VPN. The Settings window has checked "Send all traffic over VPN connection", but the IP of my public network has not changed. The problem was solved by manually canceling and selecting again

OS: Catalina

halo commented 4 years ago

Good catch!! And thank you for reporting the issue.

I did not notice this error because I'm not actively using any L2TP VPN at the moment. The checkbox looked fine in the GUI, but the GUI didn't care whether the underlying setting was a String "1" or a Number 1. I was never really sure about this.

In the version you tried, I only created a String, but it has to be a Number. This issue surfaced when I refactored the codebase from Objective-C to Swift recently.

Screen Shot 2020-01-28 at 19 20 47

It's fixed now and I released 1.0.2, you can download it here. I also added regression tests so this won't be an issue in the future. Tests are passing.

I expect it to be promoted to homebrew by someone soon. Maybe you can volunteer for that :D

I'll close this for now, feel free to contact me if you encounter any problems.

Thank you again.

halo commented 4 years ago

PS: Version 1.0.2 was quickly propagated to homebrew thanks to @tiiiecherle !