search

halogenandtoast / ArkhamHorror

An unofficial rules-compliant browser based version of Arkham Horror: The Card Game. Not produced, endorsed, or supported by, or affiliated with Fantasy Flight Games.
https://arkhamhorror.app
118 stars 39 forks source link

cant load new decks #653

Closed castoryayo closed 1 month ago

castoryayo commented 1 month ago

I cant load new decks, neither from url or file

file: https://arkham-horror-bugs.s3.amazonaws.com/exports/a0b7e71d394c73049242114646d4a30896b8a2b38309eebe2803b36b7f6890a0.json

halogenandtoast commented 1 month ago

I've looked into debugging this and I don't know what causes this (I do see what the problem is though). What is essentially happening is the game thinks your player id is something it shouldn't be and it's failing. Under normal conditions this should not happen. Your only option in this particular case is to make a new game (even if I were to fix the issue, this would not be recoverable). I'll keep looking into this issue though.

castoryayo commented 1 month ago

I have tried to create a new game. I have deleted everything (games and decks) and started again, but it still won't let me load decks. I'll try to create a new user to see what happens. I will inform you about it. Thank you All the best

El sáb, 14 sept 2024 a las 1:57, Matthew Mongeau @.***>) escribió:

I've looked into debugging this and I don't know what causes this (I do see what the problem is though). What is essentially happening is the game thinks your player id is something it shouldn't be and it's failing. Under normal conditions this should not happen. Your only option in this particular case is to make a new game (even if I were to fix the issue, this would not be recoverable). I'll keep looking into this issue though.

— Reply to this email directly, view it on GitHub https://github.com/halogenandtoast/ArkhamHorror/issues/653#issuecomment-2350718943, or unsubscribe https://github.com/notifications/unsubscribe-auth/BLIWM7A3RW7NLC7UBIM26Y3ZWN3UZAVCNFSM6AAAAABOFRYEJ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJQG4YTQOJUGM . You are receiving this because you authored the thread.Message ID: @.***>

foodiemonster commented 1 month ago

I've just encountered this same issue, tried to load a new deck from ArkhamDB and it says that the character isn't implemented yet (and it's good ol' Ashcan Pete)

foodiemonster commented 1 month ago

More info: my deck's name on ArkhamDB started with the quote symbol on it (") - I tried adding another deck and it was working fine so I decided to just remove any symbols from the deck name and try again - it worked just fine. I guess the code is getting confused by symbols in the name string for the decks on ArkhamDB

halogenandtoast commented 1 month ago

The deck name shouldn't make any difference, do you still have the failed game? The more sample sets of this issue I have the more likely I am to discover what is going wrong.

NovamationCEO commented 1 month ago

Here's a possible solution that solved this issue for me:

Unless told otherwise, arkhamdb creates decks as Private, not Public. Hitting the API for a private deck returns an incomplete payload (and a CORS error) and the message "Undefined is not implemented" (or something very close to that).

Setting my decks to Public allowed me to paste in the URL and have the deck recognized properly by arkhamhorror.app.

halogenandtoast commented 1 month ago

Here's a possible solution that solved this issue for me:

Unless told otherwise, arkhamdb creates decks as Private, not Public. Hitting the API for a private deck returns an incomplete payload (and a CORS error) and the message "Undefined is not implemented" (or something very close to that).

Setting my decks to Public allowed me to paste in the URL and have the deck recognized properly by arkhamhorror.app.

You do need your decks to be public, however, the above games were running into a different weird issues, which should be resolved now, but please reopen this issue if it is not working.