halogenandtoast / alchemist

A scientific conversion library.
155 stars 28 forks source link

Alchemist.register broken in recent version #33

Closed Nkburdick closed 10 years ago

Nkburdick commented 10 years ago

I'm getting a no method error when trying to register new units

irb(main):005:0> Alchemist.register(:volume, [:dash, :dashs], 0.125.teaspoons)
NoMethodError: undefined method `register' for Alchemist:Module
    from (irb):5
    from /usr/local/var/rbenv/versions/2.0.0-p247/bin/irb:12:in `<main>'
halogenandtoast commented 10 years ago

Alchemist.register has moved to Alchemist.library.register. This needs to change in the documentation. Additionally there's an additional step with register I'd like to remove

irb(main):001:0> require 'alchemist'
=> true
irb(main):002:0> Alchemist.setup(:volume)
=> Numeric
irb(main):003:0> Alchemist.library.register(:volume, [:dash, :dashs], 0.125.teaspoons)
=> [:dash, :dashs]
irb(main):004:0> Alchemist.setup(:volume)
=> Numeric
irb(main):005:0> 1.dash.to.teaspoons
=> #<Alchemist::Measurement:0x007f8974b105f8 @value=0.125, @unit_name=:teaspoons, @exponent=1>

The second Alchemist.setup shouldn't be required.

halogenandtoast commented 10 years ago

Changed master to delegate from Alchemist.register to Alchemist.library.register and got rid of the additional call to setup.

Nkburdick commented 10 years ago

Thanks!