search

halogenandtoast / alchemist

A scientific conversion library.
155 stars 28 forks source link

Update `BigDecimal` invocation syntax #43

Closed ahorner closed 5 years ago

ahorner commented 5 years ago

As of Ruby 2.6.0, BigDecimal.new is deprecated. We can adjust to the officially-supported syntax without any side-effects.

carlallen commented 5 years ago

This should happen!

carlallen commented 5 years ago

still waiting for this to be merged.... @halogenandtoast ?

halogenandtoast commented 5 years ago

@ahorner thanks for the PR, sorry for the delay, @carlallen thanks for the nudge, merged it in!

carlallen commented 5 years ago

also you haven't released to rubygems since 2013 and there's a few commits since then, probably good to do one soon

halogenandtoast commented 5 years ago

@carlallen I'll look into cutting a new release soon. Originally I had planned to add some new features, but life got in the way and I never finished it. Either way, no reason not to do two releases if I manage to add some more functionality later.