search

halogenandtoast / alchemist

A scientific conversion library.
155 stars 28 forks source link

Tests currently failing under Ruby 1.9 #7

Closed jduff closed 11 years ago

jduff commented 12 years ago

Haven't looked too closely at this yet, but the tests are failing in Ruby 1.9:

test_temperature(AlchemistTest):
ArgumentError: comparison of Float with Alchemist::NumericConversion failed
    /Users/johnduff/development/workspace/alchemist/test/alchemist_test.rb:77:in `test_temperature

I also noticed that in Ruby 1.9 instead of getting:

>> 5.grams
=> #<Alchemist::NumericConversion:0x101227188 @exponent=1.0, @unit_name=:grams, @value=5.0> #ruby 1.8 output

You get:

>> 5.grams
=> 5.0 # ruby 1.9 output
halogenandtoast commented 11 years ago

@jduff, @oguzbilgic it looks like it's currently working on Ruby 1.9 for me. Can you confirm this and let me know the results?

jduff commented 11 years ago

This was over a year ago and I haven't been using it for anything in awhile. If you tested and everything was good id say you're okay to close this.

halogenandtoast commented 11 years ago

@jduff Sorry I didn't get to it sooner. It at least works on 1.8.7, 1.9.3, and 2.0.0.