search

halogenica / beautifulhugo

Theme for the Hugo static website generator
Other
1.13k stars 601 forks source link

Post preview tag link has double forward slash on multilanguage website #349

Open dovidio opened 4 years ago

dovidio commented 4 years ago

Hi, first of all thanks for this wonderful theme!

I have a multilanguage website, with some default language, something like this

baseURL = "/"
defaultContentLanguage = "en"

When I'm on the page listing post previews, all the posts with tags have a wrong link with double slash //tags/:tagname which results in a 404 when clicked. I fixed it on my website in this commit I'm not sure if this would break other configurations. I can create a PR if needed

jvincentnz commented 4 years ago

@dovidio, encountered this issue and used your fix for layouts/partials/post_preview.html. I also needed to apply your fix to layouts/_default/single.htm to resolve all occurrences of the tag link having double forward slashes on my website.

See my PR #354 for the required changes.

dovidio commented 3 years ago

@jvincentnz You're right, I have overlooked that. Hopefully you're changed will get merged soon 🤞

marcosimbuerger commented 8 months ago

@halogenica can we merge PR https://github.com/halogenica/beautifulhugo/pull/354? Thank you!