search

halogenica / beautifulhugo

Theme for the Hugo static website generator
Other
1.14k stars 602 forks source link

Dark vs Light theme selection #512

Open ganomi46 opened 2 months ago

ganomi46 commented 2 months ago

Would it be possible to have light theme as default and button to allow the visitor to change the theme. I received a lot of feedback on why the theme is dark. It seem the automatic change by the browser is not very welcome. Thx

ripienaar commented 2 months ago

Strong agree, I am a huge fan of dark themes and set everything possible to dark - but this one is just not good and it's ruined beautifulhugo for me.

Xhanti commented 2 months ago

I also agree. It threw me a bit not being able to change it to light mode. It would be great to allow the user to control it.

henryiii commented 2 months ago

IMO, this is really a problem with browsers. They should provide a toggle to override the system setting, ideally per webpage. Asking webpages to all add custom toggles seems wasteful and silly. But I'd be fine with a well-implemented selector. Improvements to the colors in dark mode would be welcome as well if there's an issue with it being "not good".

henryiii commented 2 months ago

(#500 doubles the number of CSS files and doesn't add a toggle, it just lets the site author select a "non-changing light-only" theme, basically.)

hydr0nium commented 2 months ago

Yes I agree with @henryiii that it's a browser problem, but I have also been a big advocate for a change theme button. I am not really experienced with CSS, HTML much so I would be happy if someone could implement that feature. I would also be down to help as much as I can