search

halohalospecial / atom-elmjutsu

A bag of tricks for developing with Elm. (Atom package)
https://atom.io/packages/elmjutsu
MIT License
192 stars 24 forks source link

Make text within data hint inlined with styleguide #116

Closed ivan-demchenko closed 6 years ago

ivan-demchenko commented 6 years ago

I'm proposing slightly more compact styles for data hints:

screen shot 2018-04-10 at 19 17 56
halohalospecial commented 6 years ago

Thanks for the PR, @raqystyle!

Do you think we should underline the ones in orange to indicate that they are clickable?

Also, maybe it's better to also modify the Sidekick for consistency.

Thanks again!

halohalospecial commented 6 years ago

Hmm, modifying the Sidekick will take more work since we can't reuse the code from the Datatips feature. Let's do the just Datatips changes for now :)

Do you think we should underline the ones in orange to indicate that they are clickable?

ivan-demchenko commented 6 years ago

@halohalospecial I thought about it. However, in case of large sum types underlining will compromise readability.

ivan-demchenko commented 6 years ago

@halohalospecial Also, in general, I'd love to apply more styling to sum types. But that's for the future...

halohalospecial commented 6 years ago

Alright, thanks for the inputs! I'll include your changes in the next release. Thanks!

ivan-demchenko commented 6 years ago

@halohalospecial thank you! 🙏

halohalospecial commented 6 years ago

@raqystyle, the changes are already in the latest version (v7.3.6), but I had to change color: @syntax-color-attribute to color: @syntax-color-keyword because the former is not noticeable in other themes.

ivan-demchenko commented 6 years ago

@halohalospecial no worries, awesome!