Closed ymtszw closed 5 years ago
text
is replaced withexcerpt
and is now mandatory
The replacement is noted, but it looks like I missed the part where it was now mandatory when writing that.
It says
description
accepts markdown, though subset of HTML is valid in markdown, it can actually handle HTML as well
Interestingly it looks like the current implementation in linter-ui-default
runs text description
s through marked
... but currently isn't sanitizing the result from function description
s 🤦♂️. I wouldn't rely on that behaviour though as that's a bug.
And it is actually nice since it will not block our line-of-sight to actual buffer with large tooltip!
That's exactly why it isn't expanded by default 😉.
Attempts to resolve https://github.com/halohalospecial/atom-elmjutsu/issues/153
Since Linter 2.3.0 dropped Linter v1 API support, this patch upgrades Linter provider of Elmjutsu to be compatible with Linter v2 API.
I had tested this with Linter 2.3.0, linter-ui-default 1.7.1, and it seemingly works, but definitely require other people's eyes. Especially, I have not checked every kind of possible messages that can be emitted from elm compiler.
As stated in upgrade instruction:
type
is nowseverity
filePath
&range
combination is now contained inlocation
objecthtml
is removed anddescription
addedAlso, not explicitly stated but:
text
is replaced withexcerpt
and is now mandatorydescription
accepts markdown, though subset of HTML is valid in markdown, it can actually handle HTML as well (as long as it is sanitized and not contain prohibited tags, I assume)renderToStaticMarkup()
produces mostly simple and sanitized HTML, it should workOther things I found:
linter-ui-default:expand-tooltip
commandlinter-ui-default:expand-tooltip
) is key-bindable. Though it behaves in "expand while holding the key" manner.atom-ide-ui
I believe? And it is actually nice since it will not block our line-of-sight to actual buffer with large tooltip!solutions
property for quick fixes, andreferences
property for in-project references.solutions
property, since it now allows arbitrary function invocation, not just text replacement. Though at a glance, it require some extra work :P