search

halohalospecial / atom-elmjutsu

A bag of tricks for developing with Elm. (Atom package)
https://atom.io/packages/elmjutsu
MIT License
192 stars 24 forks source link

elmjutsu is overriding js-hyperclick with noop #40

Closed markogresak closed 7 years ago

markogresak commented 7 years ago

As discussed here: https://github.com/AsaAyers/js-hyperclick/issues/53

Not sure why it's overriding hyperclick in js files. Can this be fixed or at least a way to select where the hyperclick provider should work? I love the package when working with elm, but for now, I'll have to keep it disabled when working in js.

AsaAyers commented 7 years ago

Immediately before returning this promise, you need to verify that the code has the right scope for you to scan. It looks like you have that check inside the promise, so it just needs to be moved.

here is the check js-hyperclick uses to make sure I'm only scanning JavaScript files.

halohalospecial commented 7 years ago

@markogresak, @AsaAyers, thanks a lot for debugging this :heart: I was able to replicate the issue by installing js-hyperclick. @AsaAyers, thank you for pointing out the needed fix! Also, great package! I'm using it right now :smiley: