halohalospecial / atom-elmjutsu

A bag of tricks for developing with Elm. (Atom package)
https://atom.io/packages/elmjutsu
MIT License
192 stars 24 forks source link

Function.extractParams is deprecated. #43

Open halohalospecial opened 7 years ago

halohalospecial commented 7 years ago

Assigning custom properties to a marker when creating/copying it is deprecated. Please, consider storing the custom properties you need in some other object in your package, keyed by the marker's id property.

Function.extractParams (/usr/share/atom/resources/app.asar/node_modules/text-buffer/lib/marker.js:43:14)
MarkerLayer.markRange (/usr/share/atom/resources/app.asar/node_modules/text-buffer/lib/marker-layer.js:196:71)
DisplayMarkerLayer.markBufferRange (/usr/share/atom/resources/app.asar/node_modules/text-buffer/lib/display-marker-layer.js:90:62)
TextEditor.markBufferRange (/usr/share/atom/resources/app.asar/src/text-editor.js:1753:38)
<unknown> (/home/user/elmjutsu/lib/symbol-finder.js:125:40)
process._tickCallback (internal/process/next_tick.js:103:7)
mm-tfx commented 6 years ago

I have noticed this new Deprecation message:

Assigning custom properties to a marker when creating/copying it is deprecated. Please, consider storing the custom properties you need in some other object in your package, keyed by the marker's id property.

Function.extractParams - :77541:20 MarkerLayer.markRange - :78187:77 DisplayMarkerLayer.markBufferRange - :134819:58 TextEditor.markBufferRange - :4451:42 Object.flashRange - ...atom\packages\elmjutsu\lib\helper.js:429:41

- ..\.atom\packages\elmjutsu\lib\go-to.js:86:31
timjs commented 5 years ago

Any progress on this? :wink: