halohalospecial / atom-elmjutsu

A bag of tricks for developing with Elm. (Atom package)
https://atom.io/packages/elmjutsu
MIT License
192 stars 24 forks source link

Add Import: duplicate existing imports are not always removed #51

Closed mandrolic closed 7 years ago

mandrolic commented 7 years ago

Given:

module Main exposing (..)

import Html
import Array
import List
import List

import List

Then Add Import -> Task

Get:

module Main exposing (..)

import Array
import Html
import List
import Task

import List

Note 'import List' is still there twice Perhaps the clear line between duplicate 'import List' is stopping the de-duping.

module Main exposing (..)

import Html
import Array
import List
import List
import List

Seems to work OK.

I think this is another case probably, where the feature works as long as you have elm-formatted code

halohalospecial commented 7 years ago

This should be fixed in v3.5.1. Thanks!