search

halorgium / rack-client

A client wrapper around a rack app or live-http
http://halorgium.github.com/rack-client
MIT License
99 stars 28 forks source link

Add PATCH HTTP verb #18

Open nickpellant opened 10 years ago

nickpellant commented 10 years ago

This allows rack-client to perform patch requests. If the code is acceptable to the core maintainers I'd like to get this merged & tagged so that I can submit a pull request to engineyard/ey_api_hmac for a version bump.

halorgium commented 10 years ago

@nickpellant seems good. I'll get master passing again. The new rspec 3 release has broken the build.

nickpellant commented 10 years ago

@halorgium I think I know what the problem is, can push a fix to this PR for you?

halorgium commented 10 years ago

@nickpellant would you be able to push a new PR getting master green? I had some other issues:

nickpellant commented 10 years ago

@halorgium The build passed: https://travis-ci.org/halorgium/rack-client/jobs/34722494

Not sure why it's coming through as not complete on here.

nickpellant commented 10 years ago

Looking at the build @halorgium it's failing due to the test suite being run against JRuby and RBX.

halorgium commented 10 years ago

@nickpellant ah, I see you've pushed your PATCH to your master branch. I generally try to have my forks exactly track the upstream, so if situations like this arise, I can branch off of a clean slate.

I'd like to get the tests green again without your PATCH patch, for clarity. Could you branch off of halorgium/rack-client@master, file a new PR and get the tests passing?

Thanks!

nickpellant commented 10 years ago

@halorgium Take a look at #19 for work on fixing the build.