search

halorgium / rack-client

A client wrapper around a rack app or live-http
http://halorgium.github.com/rack-client
MIT License
99 stars 28 forks source link

WIP: Fix Build #19

Open nickpellant opened 10 years ago

nickpellant commented 10 years ago

Still working on this however I wanted a location to host discussion.

It appears that issues are being caused due to the lack of a Gemfile.lock, causing Travis to bundle based on the loose rules set out in the Gemfile with unexpected versions of gems. I'm locking down versions were appropriate to get the build green.

nickpellant commented 10 years ago

So there are currently two issues outstanding that I can see:

  1. Intermittent build failure because of RealWeb:
Failure/Error: Unable to find matching line from backtrace
     RealWeb::ServerUnreachable:
       Unable to reach RealWeb server after 2s: /home/travis/build/nickpellant/rack-client/spec/spec_config.ru.
       Boot RealWeb with {verbose: true} to print errrors.
  1. RBX language bug i.e.:
Failure/Error: expect(conn.put('echo', :name => 'zack').body).to eq(%(put {"name"=>"zack"}))
     NoMethodError:
       undefined method `name' on an instance of String.

I've spent as much time as I can now working to resolve this build so I'm going to need to hand it over. I think it's important to note that if we were to re-run the build for the last successful release it would also fail because the gem versions were not locked down and would now attempt to build against a different version of gems.

Unfortunately I don't have a project with a locked down Gemfile that uses a version of this gem when the build was green so I can't lock down to those versions. Do you @halorgium?

I think we would be well placed to merge these changes in and attempt to resolve the other two issues independently in new PRs, possibly disabling the Rubinius build until a later time.

Is there a hard requirement for this gem to support Rubinius?