search

halostatue / color

Color tools for Ruby.
Other
133 stars 41 forks source link

Adds an optional alpha parameter to the css_rgba method. #15

Closed Bennell closed 8 years ago

Bennell commented 9 years ago

In order to resolve a transparency issue that arose through using a hex based value, I used your gem to convert the hex to RGB.

Though the gem offered one method for converting to percentage based integers, the alpha was hard coded to 1 and I required 0.6. On this basis I added an optional alpha parameter that defaults to 1.

I hope you find this useful :)

halostatue commented 9 years ago

Looks pretty good. Can you squash these into a single commit?

Bennell commented 9 years ago

Squashed :)

halostatue commented 9 years ago

OK. I’m not going to merge this immediately because I need to get back on the status of several other in-progress things, and I won’t have time to look at that before Sunday, but this will be included in the next release.

halostatue commented 9 years ago

Thanks

Bennell commented 9 years ago

You're very welcome. Have a good weekend.

halostatue commented 8 years ago

I have released 1.8 with this feature