search

halostatue / color

Color tools for Ruby.
Other
133 stars 41 forks source link

LAB gets its own class #8

Closed daveheitzman closed 10 years ago

daveheitzman commented 10 years ago

I'm creating this changeset as a pull request rather than pushing directly to color/master as I'd rather you reviewed it and approve of the direction I'm going here.

contrast can now be passed a symbol to specify which algorithm to use. We have 3 algorithms available at present.

halostatue commented 10 years ago

Thanks—I want to release 1.6 first and then we can start working with this and another change that's been proposed (y implementation of YIQ is totally borked) to release as 2.0 next month or so.

I'll look at this over the weekend (long weekend here in Canada).

daveheitzman commented 10 years ago

That's perfect. On another note, travis keeps failing. do you know how to fix? (locally, it complains it cannot load simplecov)

halostatue commented 10 years ago

Yeah. Edit .travis.yml to remove 1.9.2 entirely; also, change rbx to rbx-2 and remove the installation of ruby-sl in the before script.

All changes I need to make on master for the next release regardless. SimpleCov appears to behave very badly under Ruby 1.9.2, and I'm not going to explicitly support it with any of my projects anymore (but I probably won't block people from upgrading to it).

As a side note, since I'm targeting LAB for Color 2.0, I'm probably going to drop Ruby 1.8 support in the same timeframe.

daveheitzman commented 10 years ago

okay, thanks. I'll just wait for you to push a change for that, and put up with travis failing for 1.9.2 in the meantime.

In my opinion, continued support for 1.8.7 would be a worthwhile priority, unless there are desirable features that very hard to implement with it.

halostatue commented 10 years ago

I'm closing this in favour of #12, which is your code here targeted to the 2.0 release. It will hopefully also pass unit tests. ;)