search

halostatue / diff-lcs

Generate difference sets between Ruby sequences.
http://halostatue.github.com/diff-lcs
Other
290 stars 57 forks source link

Various diff-lcs Fixes #39

Closed halostatue closed 7 years ago

halostatue commented 7 years ago

Fixes a number of issues/PRs that have languished:

I’m also in the process of updating to test on modern versions of Ruby, and fixing some other tooling issues.

halostatue commented 7 years ago

Pinging people interested in associated bugs: @koic, @junaruga, @strzibny, @voxik, @gkellogg, @simonc, @boutil.

voxik commented 7 years ago

History.rdoc is not updated (yet?).

voxik commented 7 years ago

Otherwise I did just quick testing. Previously, there was 4 test error in the "cucumber-wire" test suite caused by the diff-lcs warnings. They have gone with this PR.

Also the #1 and #33 seems to be resolve as far as I can say.

So things look good from my POV.

halostatue commented 7 years ago

I’ll update the History file by the weekend (there’s a few more changes that I want to make to the structure to match what I have been doing with my other projects, but those are relatively small in comparison).

I’m debating releasing this as 1.3.0-rc1 rather than 1.3 because I’m not 100% on the fix to #1. Other than that, I think we’ll see a proper 1.3 release fairly soon. Opinions on rc1?

voxik commented 7 years ago

I am slightly in favor of skipping rc1 ...

junaruga commented 7 years ago

I’m debating releasing this as 1.3.0-rc1 rather than 1.3 because I’m not 100% on the fix to #1. Other than that, I think we’ll see a proper 1.3 release fairly soon. Opinions on rc1?

In my opinion, if the fixing to #1 is not 100% sure, but it is better situation than current latest version 1.2.5, I will prefer "1.3.0" than "1.3.0.rc". The reason why I want you to release is to fix cucumber-wire's tests. we release it as "1.3.0", cucumber team can fix the tests without modification. and we may be able to get good feed back or idea to fix the issue as 100% as faster. However the fixing to #1 has critical bug such as "completely does not work" or "can not install it", "1.3.0.rc" might be better.

There are cases for using "rc" version as release operation. For example nokogiri and rails. nokogiri needs a compile to install it. it is related on native library such as libxml2 and libxslt. It is possible that it does not work completely or it can not be installed for one of the supported platform. rails is made from over than 5 gem packages such as activesupport, activemodel.. It is possible that it does not work (does not start Rails server) for one of the platform.

halostatue commented 7 years ago

OK. I’ll try to release as 1.3 this weekend.

halostatue commented 7 years ago

Release will be tonight.