Reintroduce Diff::LCS::Change#to_ary

halostatue / diff-lcs

Generate difference sets between Ruby sequences.

http://halostatue.github.com/diff-lcs

Other

290 stars 57 forks source link

Reintroduce Diff::LCS::Change#to_ary #50

Closed halostatue closed 5 years ago

halostatue commented 5 years ago

This required some level of code remediation in the main library, but all tests now pass:
- Patchsets are now internally flattened one level explicitly, rather than using Array#flatten. This ensures that only the outer patchset array is flattened.

Fixes #48.

halostatue commented 5 years ago

@knu I believe that this fixes everything. All of the tests pass, but I’d appreciate some additional eyes on this because it is a fairly large change.

knu commented 5 years ago

Sorry for the delay, I’ll look into this later today!

knu commented 5 years ago

Looks good, except that .flatten is still mentioned in a couple of places in the documentation, which should be updated.

I don't really get the idea of a "patchset" yet, but is it a mix of a single Change/ContextChange object or an array of them?

halostatue commented 5 years ago

Your reading of 'patchset' is correct; it is an ordered array of changes, where a group of related changes may themselves be an array of changes.