A fix+specs for Diff::LCS::ChangeTypeTests predicates

halostatue / diff-lcs

Generate difference sets between Ruby sequences.

http://halostatue.github.com/diff-lcs

Other

290 stars 57 forks source link

A fix+specs for Diff::LCS::ChangeTypeTests predicates #8

Closed ged closed 12 years ago

ged commented 12 years ago

The last three Diff::LCS::ChangeTypeTests predicates use a non-existant instance variable, which causes them not to work correctly.

This is a patch for those methods, and specs for them (via the Diff::LCS::Change class).

I wasn't sure what the best testing strategy was, so I tried to err on the side of the least possible code that still showed the bug and the fix. If you'd rather they were written some other way, I'd be happy to do so.

halostatue commented 12 years ago

Thanks. I know this can be automatically merged, but I want to look them over before I do so and I don't really have time for a few days. If I don't get to this by next Wednesday, could you ping me?

ged commented 12 years ago

Sure! I've actually been using this as a monkeypatch for quite a while, so a few more days won't hurt anything. I mostly just wanted to bring it to your attention.

ged commented 12 years ago

Oops, I guess I needed someone to ping me to ping you. :P

Anyways: PING.