search

halostatue / minitar

Minimal pure-ruby support for POSIX tar(1) archives.
Other
38 stars 27 forks source link

Don't use /win32/ to detect Windows #14

Closed kzys closed 7 years ago

kzys commented 8 years ago

Apparently the regexp is not enough to detect Windows.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+1.1%) to 80.583% when pulling 670470c90729cc3c8e7d6ec4daa461947aadcd87 on kzys:windows-fix into bfc5bfae3aa6582c64141f659a760824e4131884 on halostatue:master.

halostatue commented 8 years ago

It will be a little while before I can integrate this, but this will probably trigger a 1.0 release because it’s a breaking change—archive-tar-minitar still supports Ruby 1.8 which does not include RubyGems by default…so I’m going to also need to deal with a few other things to go with it.

kzys commented 8 years ago

I thought that since this library is packaged as a gem, assuming rubygem's existence is fine. Let me change that to use /mswin|mingw/ instead.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+1.2%) to 80.658% when pulling e392cda92fcc7a3414cdd58573bd35cb435c01a3 on kzys:windows-fix into bfc5bfae3aa6582c64141f659a760824e4131884 on halostatue:master.

halostatue commented 8 years ago

Although (IMO) RubyGems are the best choice for using Ruby packages, some OS distributions prefer to repackage them as OS packages, in which case you cannot assume the presence of RubyGems for a 1.8-type release. (Previous versions of this project have also been released as tarballs. In the future, I will only be providing gems.)

kzys commented 8 years ago

Makes sense. This pr doesn't have the breaking change anymore. Are you going to release 1.0 before having 0.6?

halostatue commented 8 years ago

Not sure yet. I’ve got to take stock of this code and a couple of forks that have disparate functionality. There may be a consolidation release that is version 0.6 to bring all of the code back, but I would like to have a 1.0 release at some point.

halostatue commented 7 years ago

Thanks!