halpz / re3

2.4k stars 400 forks source link

Automobile Nodes Enum Fix #18

Open JacobGlennAyers opened 10 months ago

JacobGlennAyers commented 10 months ago

Changes enum eCarNodes to start at 0 so that NUM_CAR_NODES is correct. Since the enum started at 1, NUM_CAR_NODES was 1 greater than it should be. Lead to errors when running this line in Automobile.cpp CAutomobile::SetupModelNodes(void) { int i; for(i = 0; i < NUM_CAR_NODES; i++) m_aCarNodes[i] = nil; CClumpModelInfo::FillFrameArray(GetClump(), m_aCarNodes); }

As long as it's not linux/cross-platform skeleton/compatibility layer, all of the code on the repo that's not behind a preprocessor condition(like FIX_BUGS) are completely reversed code from original binaries.

We don't accept custom codes, as long as it's not wrapped via preprocessor conditions, or it's linux/cross-platform skeleton/compatibility layer.

We accept only these kinds of PRs;

JacobGlennAyers commented 10 months ago

Now it matches what it seen in the gangs.h file: Screenshot from 2023-11-28 21-52-50