search

halsafar / BeatSaberSongBrowser

BeatSaber plugin, adds much needed functionality to the song selection interface.
MIT License
164 stars 41 forks source link

Sorting by PP not available due to empty "BeatStar" json file. #78

Closed L1Z1X closed 5 years ago

L1Z1X commented 5 years ago

It looks like pp information was previously being loaded from this endpoint which is now returns an empty json response.

This isn't the first time there's been an issue with the PP json file. I wonder if it would be possible to cache the last known good response from the endpoint to use as a fallback?

WesVleuten commented 5 years ago

Hi there, I maintain the BeatStar project which includes the pp sorting of the songbrowser.

The reason why that endpoint is now empty is because it relied on the old beatsaver key. As seen in this commit we have a new url which is better optimized (and also allows for sorting by star rating).

I'm looking at better backwards compatibility. That should be done within a couple days.

L1Z1X commented 5 years ago

Ah great. Thanks!

Resolved in #77

halsafar commented 5 years ago

Just to chime in.
Hoping to release an update today with this fixed.