search

halsafar / BeatSaberSongDataCore

A Beat Saber Plugin that manages scraped data from various sources.
MIT License
15 stars 9 forks source link

All songs show 0pp #12

Closed wesliel closed 3 years ago

wesliel commented 3 years ago

The gzip file referenced in BeatStarDatabase: https://cdn.wes.cloud/beatstar/bssb/v2-all.json.gz

Contains 0pp for all songs, therefore ranked song filtering is broken in Song Browser.

Looks like a similar issue was reported before.

wesliel commented 3 years ago

image

WesVleuten commented 3 years ago

Thank you for reporting this, I'll look into it. I'll keep you up to date.

WesVleuten commented 3 years ago

Bug seems a little more complex than I anticipated, it's gonna take longer. I don't have an ETA.

wesliel commented 3 years ago

np, thanks for looking into it. I have lots of web API programming experience, if you need a hand LMK!

ChrisJAllan commented 3 years ago

The new BeatSaver has an API endpoint to grab the scoreboard of a song with https://api.beatsaver.com/scores/{hash}/{page}?difficulty={difficulty}&gamemode={gamemode}, would that help?

(Or, for a cheap estimate, just multiply the stars by 46 or so)

WesVleuten commented 3 years ago

@ChrisJAllan Thank you for the suggestion, helped lots!

I just pushed an update, I'll be monitoring the server for if anything goes wrong but it should be alright.

ErisApps commented 3 years ago

Not sure if you noticed it already, but it doesn't look like the update fixed the issue. Ranked maps still have 0pp And the "song" and "mapper" fields are still empty for every song (or at least as far as I've checked)

wesliel commented 3 years ago

Was that a data fix? I just checked the content of v2-all.json.gz and can confirm @ErisApps report. Does the CDN need a cache purge?

ChrisJAllan commented 3 years ago

Some songs have a pp value, but something seems very wrong. For example: 61CAADA06A65088BD514E00D88397CCDEF8C7714.txt Has multiple entries for "Easy" difficulty, and no pp on any other difficulty. It also seems that all levels that have non-zero "pp" have zero "star".

So updated information is not replacing old information, and it also only seems to pull the lowest difficulty. Edit: Another example show it does sometimes get other difficulties: 0CAC133F16A319DE4788AD5F27002994E120D818.txt

halsafar commented 3 years ago

Confirmed, I'm seeing the same issues.

halsafar commented 3 years ago

PP should be working again. You might need to delete the files located here: %USERPROFILE%\AppData\Local\Temp\Hyperbolic Magnetism\Beat Saber\WebCache

halsafar commented 3 years ago

Looks like the issue is back again 🥴. Working on it.

halsafar commented 3 years ago

Okay, PP is working again (and filter by ranked in SongBrowser). I'll close this when it appears stable a few others have confirmed.