search

haltakov / simple-photo-gallery

Beautiful and simple photo galleries that help you tell your story. Free and open-source.
https://haltakov.net/simple-photo-gallery
MIT License
194 stars 51 forks source link

gallery.json is not populated as in description #105

Closed pleabargain closed 3 years ago

pleabargain commented 3 years ago

I'm running simple-photo-gallery 1.5.0

https://github.com/haltakov/simple-photo-gallery/blob/master/doc/GalleryConfiguration.md

https://i.imgur.com/MUJbLDh.png

I was looking for a way to enable description in the gallery.json but the param was not there. disbale_captions (which is a typo too, I posted that fix here: https://github.com/haltakov/simple-photo-gallery/pull/104

image

I'm having trouble importing the pip file into the python terminal to sort the CORRECT usage of disable_captions

haltakov commented 3 years ago

The default behavior is that you don't need to set disable_captions to false to have the captions. So, is the problem that you are not seeing any captions?

pleabargain commented 3 years ago

The problem is that there is NO option in the gallery.json to turn them on or off :) Gallery json doesn't have a caption disable option.

haltakov commented 3 years ago

Sorry, I kind of forgot about this thread...

I think I see your point - in the gallery.json that is created, there is no disable_captions entry, right? You can just add it yourself, but I agree it will be better to have one by default there as well.

haltakov commented 3 years ago

OK, I fixed it now. I also found a bug that the parameter didn't work at all and fixed it as well. You can check it with version 1.5.2.

pleabargain commented 3 years ago

Thank you! Will do!

On Fri, May 14, 2021 at 12:18 AM Vladimir Haltakov @.***> wrote:

OK, I fixed it now. I also found a bug that the parameter didn't work at all and fixed it as well. You can check it with version 1.5.2.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/haltakov/simple-photo-gallery/issues/105#issuecomment-840840659, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAE4OTXKOBRL4UTBZALXOBDTNQ6Z5ANCNFSM42KFDVHA .