Open r0bgus opened 6 months ago
I tried to test spg using a google photo gallery and I am getting an error
Something went wrong while generating the images_data.json file: WebDriver.__init__() got an unexpected keyword argument 'executable_path'
which i traced to an update to selenium in June 2023. Do you not see this error when you use spg with a google photo album? are you using an older version of selenium?
selenium 4.0.0b4 geckodriver v0.33 firefox v120 (v121 had some issues with selenium/geckodriver)
after i downgraded selenium, then i was getting error traced to geckodriver. I see you are using a more recent version than is bundled with this package. did you just update geckodriver after you installed spg or ... ? sorry for so many questions. I want to fix this but I am learning how this package works and want to make sure i understand completely so i know the proper approach to fixing. thanks.
I did update it after installing spg. It's important you get the right combination of browser version and driver specific to your environment.
I opened new issue #135 to address Selenium issue.
I put your proposed change on a branch issue/134-google-limit
to make it easier to review and test. I havent tried to test it yet. It is based on the branch for #135 because that is needed anyway to make SPG work with remote albums.
When creating a gallery from google drive, the current xpath is limited to 30 images. It seems like google photos only loads up to 30 photos at any time.
I created a POC for the GoogleGalleryLogic class. It will scroll the gallery and capture every available photo.