search

haltcase / glob

Pure Nim library for matching file paths against Unix style glob patterns.
https://glob.bolingen.me
MIT License
61 stars 5 forks source link

`includeDirs` should default to true, as in D, python, unix find, unix ls, etc #18

Open timotheecour opened 6 years ago

haltcase commented 6 years ago

@timotheecour hmm. It seems more common that I'd want to not match directories, and that's what I'm used to from most libraries in the JS realm. This is a possibility but I don't want to be consistent just for the sake of consistency — it should also be sane.

timotheecour commented 6 years ago

not a big deal ultimately whichever way you prefer, however here's 1 more argument: with current default, walkGlobKinds only entries with returns kind=file (real or symlink), so (with default options), the kind argument isn't particularly useful with includeDirs defaulting to true, the kind becomes more meaningful