feat(walk): make `Absolute` option handling smarter

haltcase / glob

Pure Nim library for matching file paths against Unix style glob patterns.

https://glob.bolingen.me

MIT License

61 stars 5 forks source link

Closed haltcase closed 6 years ago

haltcase commented 6 years ago

Closes #23

`Absolute in options` ?	root	pattern is absolute?	paths returned as
`true`	irrelevant	irrelevant	absolute
`false`	`""` (default)	no	relative
`false`	`""` (default)	yes	absolute
`false`	not `""`	irrelevant	relative

BREAKING CHANGE: absolute patterns now result in absolute paths if no root is provided (even if Absolute notin options)

cc @timotheecour

timotheecour commented 6 years ago

@citycide anything holding back on this issue? (haven't tried it but I can after you merge :) )

haltcase commented 6 years ago

Not really, just started a new gig so I've been wrapped up :laughing: I'll merge now.

(edit: let's try to remember to add some additional tests though)