search

halu5071 / git-push-hackathon

$ git push hackathon :computer:
https://www.cyberagent.co.jp/
1 stars 0 forks source link

ready Entity #5

Closed halu5071 closed 6 years ago

halu5071 commented 6 years ago

on domain layer

In this app, data layer does not have entity package, because both data and domain layer will use the same entities, and data layer can use entities on domain layer

Add Test

halu5071 commented 6 years ago

Critical Changes

https://github.com/halu5071/til/blob/master/2018/0125.md

I will change architecture from module-based clean architecture to package-based clean architecture

Because dagger injection on presentation can not refer to libraries on other modules. For example, Retrofit on data layer require OkHttp reference then provideRetrofit() method has okHttpClient argument. However, in this case, dagger can not find OkHttpClient reference on data layer.