feat: item CRUD 기능 구현 - [merged]

[halucinor]

_Merges feature/item_curd2 -> develop

작업 내용

• [x] Item CRUD 기능 개선
• [x] ItemOption CRUD 기능 구현
• [x] ItemImage CRUD 기능 구현
• [x] 인증/인가 기능 추가
• [x] imageupload 기능 구현
• [x] item 상품 예약 오픈 기능 구현

  주의사항

• 테스트 코드 TBD
• 인증/인가 TBD

Issues #20 #21 #22 #37 #36

• [X] 🧹 불필요한 코드는 제거했나요?
• [X] 💭 이슈는 등록했나요?
• [X] 🏷️ 라벨은 등록했나요?
• [X] 💻 git merge를 사용했나요?

[halucinor]

In GitLab by @haaeee on Feb 20, 2023, 17:00

Commented on src/main/java/com/gabia/bshop/dto/request/ItemOptionRequest.java line 8

null 체크하셔야될 것 같습니다!!

[halucinor]

added 1 commit

• 8706e600 - fix : ItemOptionRequest @NotNull 추가 및 ItemOptionChangeRequest 제거

Compare with previous version

[halucinor]

In GitLab by @haaeee on Feb 20, 2023, 17:59

approved this merge request

[halucinor]

In GitLab by @rkdud1108 on Feb 20, 2023, 20:36

Commented on src/main/java/com/gabia/bshop/controller/ItemController.java line 45

createItem 오타

[halucinor]

In GitLab by @rkdud1108 on Feb 20, 2023, 22:33

Commented on src/main/java/com/gabia/bshop/exception/ErrorCode.java line 31

ITEM_OPTION_NOT_FOUND_EXCEPTION(NOT_FOUND, "itemId: {0}의 optionId: {1} 를 찾을 수 없습니다."),
...
ITEM_ITEMOPTION_NOT_FOUND_EXCEPTION(NOT_FOUND, "유효하지 않은 상품이 존재합니다."),

OPTION인 것도 있고 ITEMOPTION인 것도 있어서 하나로 통일하면 좋겠다는 생각입니다.

[halucinor]

added 3 commits

• 971a7e40 - feat: 상품예약 CR(U)D 기능 구현
• c621158c - chore : error
• faf09e6c - feat: 상품 예약 기능 구현

Compare with previous version

[halucinor]

changed this line in version 13 of the diff

[halucinor]

added 1 commit

• 36872c5d - fix: ItemController creatItem -> createItem

Compare with previous version

[halucinor]

수정했습니다~

[halucinor]

In GitLab by @haaeee on Feb 21, 2023, 13:07

Commented on src/main/java/com/gabia/bshop/controller/ItemImageController.java line 32

url 변경점에서 오류가 있는 것 같습니다!

[halucinor]

In GitLab by @haaeee on Feb 21, 2023, 13:08

Commented on src/main/java/com/gabia/bshop/controller/ItemOptionController.java line 52

items 로 변경해야 될 것 같습니다

[halucinor]

changed this line in version 14 of the diff

[halucinor]

added 1 commit

• 492b4c3e - fix : url error

Compare with previous version

[halucinor]

changed this line in version 15 of the diff

[halucinor]

added 1 commit

• c705a074 - fix : url error item -> items

Compare with previous version

[halucinor]

In GitLab by @haaeee on Feb 21, 2023, 13:14

Commented on docker-compose.yml line 30

9000번에 해당하는 포트와 9001번에 해당하는 포트가 사용중이면 사용의 문제가 있을 수 있기에 환경변수 처리하는게 좋을 것 같습니다.

[halucinor]

In GitLab by @haaeee on Feb 21, 2023, 13:18

Commented on src/main/java/com/gabia/bshop/util/ImageValidate.java line 29

그리고 imageUrl에 대한 에러처리에서 image가 존재하는 것의 문제가 아닌

imageUrl의 잘못되었기에 NotFound 에러가 맞나요?

[halucinor]

In GitLab by @haaeee on Feb 21, 2023, 13:19

Commented on src/main/java/com/gabia/bshop/util/ImageValidate.java line 26

매번 객체가 생성되는되 환경변수로 주입 받는 방식으로 변경하면 좋을 것 같습니다.

[halucinor]

added 1 commit

• 365583ef - feat : item year 추가

Compare with previous version

[halucinor]

changed this line in version 17 of the diff

[halucinor]

added 1 commit

• be9ad76b - refactor: docker-compose.yml minio_port, minio_web_port 환경변수 처리

Compare with previous version

[halucinor]

changed this line in version 18 of the diff

[halucinor]

changed this line in version 18 of the diff

[halucinor]

added 1 commit

• e6ff4257 - refactor: UrlValidatorConfig로 객체를 재사용하는 방식으로 변경

Compare with previous version

[halucinor]

In GitLab by @haaeee on Feb 21, 2023, 13:57

Commented on src/main/java/com/gabia/bshop/config/UrlValidatorConfig.java line 9

필요없는 생성자는 제거하셔야할 것 같습니다.

[halucinor]

changed this line in version 19 of the diff

[halucinor]

added 1 commit

• f6525c9d - refactor: 불필요 @RequiredArgsConstructor 제거, Notfound -> BadRequest

Compare with previous version

[halucinor]

changed this line in version 20 of the diff

[halucinor]

added 1 commit

• 02f8eacf - refactor: ERRORCODE 수정, ItemReservationRepository -> ReservationRepository

Compare with previous version

[halucinor]

In GitLab by @haaeee on Feb 21, 2023, 14:26

resolved all threads

[halucinor]

ITEM_ITEMOPTION_NOT_FOUND_EXCEPTION(NOT_FOUND, "유효하지 않은 상품이 존재합니다.") 은 잘못된 요청에 대한 에러메시지 이므로 Badrequest로 수정해서 업로드하였습니다.

[halucinor]

added 1 commit

• e46af57f - refactor: NotFundException -> BadRequestException

Compare with previous version

[halucinor]

In GitLab by @haaeee on Feb 21, 2023, 14:31

Commented on build.gradle line 84

포맷팅 한번 해야 할 것 같습니다. 혹시 저희가 쓰는 형식으로 변경 가능할까요??

implementation group: 'io.minio', name: 'minio', version: '8.3.6'

[halucinor]

added 1 commit

• 308897ca - fix : test code conflictexception -> Badrequestexception

Compare with previous version

[halucinor]

added 1 commit

• 3f1c3ea6 - chore: gradle format 수정

Compare with previous version

[halucinor]

해당 내역 다음 브랜치에서 적용했습니다. 3f1c3ea6

[halucinor]

In GitLab by @haaeee on Feb 21, 2023, 15:53

Commented on build.gradle line 84

감사합니다!

[halucinor]

In GitLab by @haaeee on Feb 21, 2023, 15:54

resolved all threads

[halucinor]

mentioned in commit 30ece52bdb3a7a0e2b2153c43ca9491df8588af8

[halucinor]

In GitLab by @haaeee on Feb 21, 2023, 15:54

mentioned in commit 8cdace0f94b4c460586351c7018d8ce1173575de

[halucinor]

In GitLab by @haaeee on Mar 7, 2023, 10:00

mentioned in commit 07d25fd7dbcc3ecadd855f90f140b2f2b61d3c1f

[halucinor]

mentioned in commit 2e0e481faed37aba8c40035da5d200b28c6ed1af

[halucinor]

mentioned in commit 9b6efe6bde5fbf30a19e6118d5a5900e2e962383

[halucinor]

In GitLab by @rkdud1108 on Mar 18, 2023, 12:58

mentioned in commit f69407b6bce153198d48f198c33983b58b0e3a85