Closed halucinor closed 1 year ago
In GitLab by @Kai on Jan 10, 2023, 16:02
Commented on src/main/java/com/gabia/evoting/web/dto/AgendaResponseDto.java line 31
컨벀μ μ νμ¬ λ€μ μμ νκ³ μλ건κ°μ? snake_case ννκ° μλλ° λ³κ²½μ μνλ μ΄μ κ° νΉμ λ°λ‘ μλμ§ κΆκΈν΄μ λ¬Όμ΄λ΄ λλ€.
In GitLab by @Kai on Jan 10, 2023, 16:02
Commented on src/main/java/com/gabia/evoting/web/AgendaController.java line 64
PutMapping
μ μ¬μ©νκΈ°μλ μ‘°κΈ μμ¬μ 보μ
λλ€. λ€λ₯Έ HTTP Method κ° μλμ§ νλ² μ°Ύμ보μΈμ.
In GitLab by @Kai on Jan 10, 2023, 16:02
Commented on src/main/java/com/gabia/evoting/web/AbstractController.java line 47
νμ¬ AbstractController
λΌλ μΆμ ν΄λμ€λ μ΄λ€ μν μ νκΈ° μν ν΄λμ€μΈκ°μ?
κ·Έλ¦¬κ³ getUser
, isGuestUser
λ©μλλ λμ€μ Controller μμ μ¬μ©νκΈ° μν΄ λ―Έλ¦¬ μ μν κ²μΈκ°μ?
pythonμμ μ¬μ©νλ 컨벀μ μ΄ μμ μ΅μ΄ κ°λ snake_case ννκ° λμ€λ κ±° κ°μ΅λλ€;; π 컨벀μ μ κ°λ μ±μ μν΄ camel caseλ‘ λ³κ²½νλ €κ³ νκ³ μμ΅λλ€. μ°Ύμμ£Όμ μ κ°μ¬ν©λλ€!
In GitLab by @Charlie on Jan 10, 2023, 16:12
Commented on src/main/java/com/gabia/evoting/web/AgendaController.java line 47
HTTP Status Code λ 무μμ΄ μκ³ κ°κ°μ 무μμ μλ―Ένλμ? μ€κ³νμ κ° API μλ΅μ μλ΅ μ½λκ° μ ν©νμ§λ₯Ό κ³ λ―Όν΄λ³΄μλ©΄ μ’μ κ² κ°λ€μ.
PatchMapping
μΌλ‘ λ³κ²½ν΄λ³΄κ² μ΅λλ€ :D
AbstractController
λ 컨νΈλ‘€λ¬μμ 곡ν΅μ μΌλ‘ μ¬μ©ν κΈ°λ₯μ λν μΆμνμ ꡬνμ μν ν΄λμ€μ
λλ€.
getUser
, isGuestUser
μΈμ¦ κΈ°λ₯μ ꡬννλ©΄μ κΈ°λ₯μ μΆκ°νκ±°λ μ κ±°ν κ³νμ λλ€.
In GitLab by @Pablo on Jan 10, 2023, 16:30
Commented on src/main/java/com/gabia/evoting/service/AgendaService.java line 23
λ¨μ μ‘°νκ° λ°μλλ μλΉμ€ λ‘μ§ κ°μλ°
@Transactional
μ΄λ
Έν
μ΄μ
μ νμ©νμ μ΄μ κ° μμκΉμ?
볡λΆνλ€κ° @Transectional
μ΄ κ°μ΄ λ€μ΄κ°κ² κ°μ΅λλ€...
λ€μ μνμ½λμ λν λ¬Έμλ₯Ό νμΈνμ¬ μμ νκ² μ΅λλ€.
changed this line in version 2 of the diff
changed this line in version 2 of the diff
changed this line in version 2 of the diff
In GitLab by @Pablo on Jan 10, 2023, 16:48
Commented on src/main/java/com/gabia/evoting/service/AgendaService.java line 23
νμΈνμ΅λλ€. :smiley:
In GitLab by @Luke on Jan 10, 2023, 16:50
Commented on src/main/java/com/gabia/evoting/service/AgendaService.java line 36
λΉλ ν¨ν΄μ λν΄μ μ°Ύμ보면 μ’μλ― μΆμ΅λλ€ :)
changed this line in version 3 of the diff
builder ν¨ν΄ μ μ©ν΄μ μ½λ μμ ν΄λ΄€μ΅λλ€ :smile:
In GitLab by @Charlie on Jan 10, 2023, 17:12
Commented on src/main/java/com/gabia/evoting/web/dto/AgendaResponseDto.java line 31
μ½λ© 컨벀μ μ μ€μκ° λμ¬ μ μκ³ , μ¬λ¬ μμ μκ° ν¨κ» κ°λ°νλ€λ©΄ 컨벀μ μ λμ± μ§μΌμ§κΈ° μ΄λ €μΈ μ μμ΅λλ€.
μ΄λ° λ¬Έμ λ₯Ό ν΄κ²°ν μ μλ λ°©λ²μ΄ 무μμ΄ μμμ§ κ³ λ―Όν΄λ³΄λ κ²λ μ’μ κ²½νμ΄ λ κ² κ°λ€μ.
In GitLab by @Charlie on Jan 10, 2023, 17:14
Commented on src/main/java/com/gabia/evoting/web/AgendaController.java line 64
/agenda
λΌλ URL μ μ ν©νκ°μ? collection κ³Ό resource μ μ°¨μ΄λ 무μμΈμ§ μκ°ν΄λ³΄μΈμ.
In GitLab by @Pablo on Jan 10, 2023, 17:20
Commented on src/main/java/com/gabia/evoting/web/AbstractController.java line 27
~QUESTION
successMessage
λ©μλλ μ¬λ°λ₯Έ μλ΅ κ²°κ³Όμ ꡬ쑰λ₯Ό ν΅μΌνκΈ° μν΄ μμ±νμ κ² κ°μλ°,
κ·ΈλΌ Controllerμμ failureMessage
λ©μλλ μ΄λ»κ² νμ©νμ€ κ³νμΈκ°μ?
failureMessage
μλ μ€ν¨ μ¬μ μ λν κ°λ¨ν descriptionμ data
μ λ£μ΄ return νλ €κ³ μκ° μ€ μ
λλ€.
In GitLab by @Pablo on Jan 11, 2023, 20:10
Commented on src/main/java/com/gabia/evoting/web/AbstractController.java line 27
~QUESTION
failureMessage
μλ μ€ν¨ μ¬μ μ λν κ°λ¨ν descriptionμdata
μ λ£μ΄ return νλ €κ³ μκ° μ€ μ λλ€.
νμ¬λ‘μ μ€ν¨
λΌλ λΆλΆμ΄ μ¬λ°λ₯Έ μ±κ³΅ μΌμ΄μ€μ API μλ΅μ΄ μλ κ²½μ°
μ λλΌκ³ μκ°νκ³ μ§λ¬Έλ립λλ€.
μ΄λ€ κ²½μ°μ μ€ν¨
λ₯Ό λνλ΄κΈ° μν¨μΈμ§ μλ₯Ό λ€μ΄ λ§μν΄μ£Όμ€ μ μμκΉμ?
(Service λ‘μ§μμ μλν μ€ν¨μΈμ§, μλνμ§ μμ μ€ν¨μΈμ§, νΉμ λλ€ ν¬ν¨νλμ§)
λ κ·Έλ¬ν 무μΈκ°μ μ€ν¨κ° λ°μνμ λ, Controllerμμ μ½λλ‘ μ΄λ»κ² ννν μκ°μ΄μ κ°μ?
λν μ€ν¨
λΌλ κ²½μ°κ° μμΈκ° λ°μλ κ²½μ°λΌλ©΄,
μμΈ λ°μνμ λ Controllerμμ failureMessage
λ©μλλ₯Ό νμ©νλ κ² λ³΄λ€
ν΅μΌλ API μλ΅ κ΅¬μ‘°λ₯Ό λνλΌ μ μλ λ μ’μ λ°©μμ΄ μμ κ² κ°μ΅λλ€.
collection
μ μμμ μ§ν© κ·Έλ¦¬κ³ resource
λ νλμ μμμ μλ―Έν©λλ€.
λ¨μΌ agenda
μ λν λ³κ²½ URIλ₯Ό λ€μκ³Ό κ°μ΄ λ³κ²½νκ² μ΅λλ€.
PUT /agenda
-> PATCH /agendas/{id}
μ κ° κ΅¬ν μ μκ°νλ μ€ν¨
λ
μ΄ λκ°μ§λ₯Ό λͺ¨λ ν¬ν¨νκ³ μμ΅λλ€. μ§κΈ ꡬνλ μνλ‘λ, μ€ν¨μ λν μ μκ° λͺ¨νΈνμ¬ ν΅μΌλ κ΅¬μ‘°λ‘ API μλ΅μ νκΈ° νλ€κ±° κ°μ΅λλ€. :disappointed:
HTTP μν μ½λλ₯Ό μ°Έκ³ νμ¬ μ¬λ¬ μν©μ λ°λ₯Έ μμΈμ²λ¦¬ λ‘μ§μ λ°λ‘ ꡬννλ λ°©ν₯μΌλ‘ λ€μ ꡬνν΄λ³΄κ² μ΅λλ€.
μ°Έκ³ https://velog.io/@aidenshin/Spring-Boot-Exception-Controller
resolved all threads
changed this line in version 4 of the diff
TODO
dev λΈλμΉλ‘ λ¨Έμ§ ν λλ¨Έμ§ λ΄μ©μ μλ£λμ§ μμ λΆλΆμ λν΄ λ€μ ꡬννκ² μ΅λλ€ :smile:
approved this merge request
mentioned in commit 24f4e54e56c7660fc13f01ea3f79a825ef031d92
In GitLab by @Pablo on Jan 12, 2023, 13:10
Commented on src/main/java/com/gabia/evoting/web/AbstractController.java line 27
HTTP μν μ½λλ₯Ό μ°Έκ³ νμ¬ μ¬λ¬ μν©μ λ°λ₯Έ μμΈμ²λ¦¬ λ‘μ§μ λ°λ‘ ꡬννλ λ°©ν₯μΌλ‘ λ€μ ꡬνν΄λ³΄κ² μ΅λλ€.
~CHECK
- Service λ‘μ§μμ μλν μ€ν¨
- μ¬μ©μμ μλͺ»λ μμ²μ μν μ€ν¨
μ¬μ©μμ μλͺ»λ μμ²μ μν μ€ν¨
λν μ€ν¨ μΌμ΄μ€λ₯Ό μ΄λ ν κ΄μ μΌλ‘ 보λμ§μ λ°λΌ μλν μ€ν¨
λ‘ κ°μ£Όν μ μμ κ² κ°μ΅λλ€.
In GitLab by @Pablo on Jan 12, 2023, 13:10
resolved all threads
In GitLab by @Charlie on Jan 12, 2023, 13:23
Commented on src/main/java/com/gabia/evoting/web/AgendaController.java line 64
~CHECK
Merges feature/agendaService -> dev
@mentor/mentor_2023.01
π Description
μ건 μμ±, μ‘°ν κΈ°λ₯ ꡬν
π» How To Test