halvardssm / deno-nessie

A modular Deno library for PostgreSQL, MySQL, MariaDB and SQLite migrations
MIT License
527 stars 31 forks source link

[Bug]: mysql dependency breaks after new deno_std release 0.160.1 #160

Closed mechanoid closed 1 year ago

mechanoid commented 2 years ago

Operating System

macOS Ventura 13.0

Deno version

1.26.2

Nessie version

2.0.9

Bug description

deno_std@0.160.1 was released today, and the mysql driver depends on god_crypto, that had incorporated the std lib without version reference. The mysql driver has an issue for that and already implemented a fix (see https://github.com/denodrivers/mysql/issues/131) which is not yet released as far as I can see.

This results in an error like:

Warning Implicitly using latest version (0.161.0) for https://deno.land/std/hash/mod.ts
error: Module not found "https://deno.land/std/hash/mod.ts".
    at https://deno.land/x/god_crypto@v0.2.0/src/eme_oaep.ts:1:28

Would be great if nessie can be updated short after the mysql patch has been delivered.

Thanks a lot in advance!

Steps to reproduce

  1. install nessie
  2. run nessie

Aditional information

No response

mechanoid commented 1 year ago

thx @pandres95 !

This allows to reference your fork for now

import { ... } from "https://raw.githubusercontent.com/bloque-app/deno-nessie/4061847ac25849a19a2438f560bf7dede79fec54/mod.ts"  

or via jsdelivr if you don't like referencing github without CDN

import { ... } from "https://cdn.jsdelivr.net/gh/bloque-app/deno-nessie@4061847ac25849a19a2438f560bf7dede79fec54/mod.ts"

The updated mysql driver works fine for me 🥳

halvardssm commented 1 year ago

Hey @pandres95 @mechanoid ! New version has been released 2.0.10 🎉

mechanoid commented 1 year ago

@halvardssm super cool, thx a lot 🙇‍♂️