search

halvardssm / deno-nessie

A modular Deno library for PostgreSQL, MySQL, MariaDB and SQLite migrations
MIT License
527 stars 31 forks source link

[BUG] Expermental Mode never populates nessie_migrations table #93

Closed Teddy-Schmitz closed 3 years ago

Teddy-Schmitz commented 3 years ago

System (please complete the following information):

Describe the bug When a migration is run with experimental mode turned on the nessie_migrations table never gets populated.

I took a look at the code in AbstractClient.ts and it seems that if experimental mode is enabled it will never get to QUERY_MIGRATION_INSERT because thats behind the else on line 223.

To Reproduce Steps to reproduce the behavior:

  1. Run a migration with experimental mode on
  2. Check nessie_migrations table

Expected behavior nessie_migrations table should have values in it.

halvardssm commented 3 years ago

Hi @Teddy-Schmitz ! Thank you for submitting this issue! It seems to be the case as you have described, would you like to try to submit a PR? If not, I will have a look over the weekend/next week 😄

Teddy-Schmitz commented 3 years ago

Sure I'll take a look at it