halvardssm / deno-nessie

A modular Deno library for PostgreSQL, MySQL, MariaDB and SQLite migrations
MIT License
527 stars 31 forks source link

Fix the experimental tests and make sure experimental mode is working #94

Closed Teddy-Schmitz closed 3 years ago

Teddy-Schmitz commented 3 years ago

Fixes #93

Is this a breaking change?

Checklist:

Please review the guidelines for contributing to this repository.

When all of the above is completed, request a review from one of the codeowners.

Description:

I discovered a few issues unrelated to the original bug report. It looks like tests were never running on the experimental code as the config in the experimental folder was pointing to the regular cli folder. I fixed this and then noticed that seeding functionality was never ported over to experimental mode so I fixed that as well.

Teddy-Schmitz commented 3 years ago

Not sure why tests are failing I didnt change how things connect for tests. Works fine locally

halvardssm commented 3 years ago

It seems like there is something wrong with the database services used in the ci. I will take a look at it and see if anything got updated with github ci since last release.

Teddy-Schmitz commented 3 years ago

Are you able to restart the jobs? I dont see a button to retry without having to push something.

halvardssm commented 3 years ago

I have tried to figure out why this would not be working, but my best guess at this point is that there is something wrong with deno on the github runner. I have tested it locally, so I will merge this story in now, but wait with updating the version until I have found a workaround. Thank you so much for your work!