search

halvors / Nuclear-Physics

Nuclear Physics is a mod that brings in realistic, world-based technological advancement experience into Minecraft.
GNU General Public License v3.0
12 stars 8 forks source link

Various fixes and improvements #57

Open kmecpp opened 6 years ago

kmecpp commented 6 years ago

I will do more work on Quantum Assemblers but didn't have time to fix all the issues with BlockPos, which wasn't being loaded on readFromNBT.

To fix combining turbines and and some other issues, I stopped it from being cached in BaseTile. However, when you login, the packets don't send immediately. I wasn't sure how else to fix that so I lowered the packet transfer update rate in TileElectricTurbine. it looks better but I feel like there should be a better fix.

Water still doesn't boil though and I'm not sure why

halvors commented 6 years ago

@kmecpp Thanks for your contribution, there's only one problem. Nuclear Physics does all change to 1.10.2 branch, and backports those changes to 1.7.10. For 1.7.10 specific issues it should be changed on the 1.7.10 branch, but for general fixes and changes those should be made on the 1.10.2 branch.

There's many great changes and fixes here, very good work :) But for the reasons mentioned above, i'd have to apply this PR manually on the 1.10 branch, and the 1.7 specific on the 1.7 branch.

I'll do this when i have some spare time, i'll of course give you credit :)

But keep in mind for next time, try to target 1.10 branch when sending pull request, if it's not 1.7.10 specific code. The fixing of BlockPos thing is surely something to target 1.7.10 for :)

Thank you very much, i'll consider giving you access directly to this GIT respository at a later time.