search

ham-radio-software / D-Rats

D-Rats program for D-Star Ham Radios
https://iz2lxi.jimdofree.com/
Other
43 stars 13 forks source link

Fixes for version.py and d-rats_repeater.py #247

Closed wb8tyw closed 1 year ago

wb8tyw commented 1 year ago

d-rats_repeater.py: Fix saving of optional additional devices.

d_rats/version.py: Was not handling if the git program was not installed.

riggs498 commented 1 year ago

I will retry it later today. The fix you gave yesterday fixed the issue.

On Wed, Sep 20, 2023, 9:29 AM John E. Malmberg @.***> wrote:

@wb8tyw https://github.com/wb8tyw requested your review on: #247 https://github.com/ham-radio-software/D-Rats/pull/247 Fixes for version.py and d-rats_repeater.py.

— Reply to this email directly, view it on GitHub https://github.com/ham-radio-software/D-Rats/pull/247#event-10423280903, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADTNHB4XSVBKECCYSCAQIM3X3LVSNANCNFSM6AAAAAA475ZWJU . You are receiving this because your review was requested.Message ID: @.***>

flyingfrawg commented 1 year ago

John,

Can’t confirm this fix. When I brought up d-rats_repeater.py, I could not get the system to recognize any COM port except 4 (a Bluetooth port), which does not have anything radio configured.

As time permits, I may be able to test the other options, particularly the AGWPE “port” – I use UZ7HO which does provide it. The earlier “non-python” executable does seem to see my IC-9700 which is on COM22 and 23 . Sort of stretched for time so troubleshooting isn’t an option. Ideas?

Jack Spitznagel – KD4IZ

Science River LLC

Biomedical Consulting Services

From: John E. Malmberg @.> Sent: Wednesday, September 20, 2023 09:29 To: ham-radio-software/D-Rats @.> Cc: flyingfrawg @.>; Review requested @.> Subject: Re: [ham-radio-software/D-Rats] Fixes for version.py and d-rats_repeater.py (PR #247)

@wb8tyw https://github.com/wb8tyw requested your review on: #247 https://github.com/ham-radio-software/D-Rats/pull/247 Fixes for version.py and d-rats_repeater.py.

— Reply to this email directly, https://github.com/ham-radio-software/D-Rats/pull/247#event-10423280915 view it on GitHub, or https://github.com/notifications/unsubscribe-auth/AIOGDGJQNU3HXWCEELSJMQDX3LVSNANCNFSM6AAAAAA475ZWJU unsubscribe. You are receiving this because your review was requested. https://github.com/notifications/beacon/AIOGDGLHRYZA3QKSSHTKV33X3LVSNA5CNFSM6AAAAAA475ZWJWWGG33NNVSW45C7OR4XAZNWJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XKUY3PNVWWK3TUL5UWJTYAAAAAE3KGUUJQ.gif Message ID: < @.> @.>

wb8tyw commented 1 year ago

The repeater bug was simply that putting any data in the devices field caused the program to crash instead of running. That was all that was fixed. I have only tested the repeater using internet connections. The other connection types are just copies of the code from the client, and the connection types added for the python3 version at the request of someone on the mailing list have never been tested.

wb8tyw commented 1 year ago

In any case, these two fixes have already been tested separately by the original people who were tripped up by the bug, so just need a reviewer to mark it approved so that I can merge it, and move on to working on the PR in progress to get internationalization working acceptably.

Once the internationalization PR is complete and merged, it will a good spot create a new minor release.