hama3254 / Crunchyroll-Downloader-v3.0

Downloader for Crunchyroll
837 stars 110 forks source link

Simultaneous Download Bug #134

Closed kanohn closed 3 years ago

kanohn commented 3 years ago

Well, i don't know if its working as expected, but on the options "Simultaneous Download" is marked as 1, and sometimes the program let 2 animes to download at the same time when i put some animes on queue. It don't occour all time, only sometimes..

Prints: https://ibb.co/Dbxbr1P https://ibb.co/rbmCMsL

I tried to figure it out and search for "Simultaneous Download" to check the code on source, but it seems it's using dll to make the check? https://ibb.co/rMF4q96

hama3254 commented 3 years ago

How did you add the second download? Was it from the Multi download, from the Queue or added directly? . The public variable for the check is namend MaxDL in the Main.vb

kanohn commented 3 years ago

I add download to the queue by clicking on "+" button everytime. Also i need to stay with the queue list opened to the download starts automatically, if i close the queue and stay on the program home, it's not start. So when i need to add more to queue, i close the queue and click on "+" to add. Maybe i'm adding on the wrong way?

Also i don't know how to add from "Multi Download", i only see that option on Crunchyroll -> Subtile Download.

Prints: https://ibb.co/dGFGs3c https://ibb.co/gJ6ctD0

hama3254 commented 3 years ago

Also i don't know how to add from "Multi Download", i only see that option on Crunchyroll -> Subtile Download

For crunchyroll just use the overview page of the Anime as url to add, then you get a selection for seasons (if there is more than one) and episodes. Just select a start episode and a stop episode from the drop down then press download. It will add each episodes on itself.

kanohn commented 3 years ago

I will try that way..

However i made some changes on the code to test and it seems to be fixed for the other way.. you could check to see if its correct and adjust the code..

https://www.diffchecker.com/H8tqPZDi

Edit: Not fixed.

kanohn commented 3 years ago

For do what you said, i need the add on for the browser, right? and enable http server on the options i think.. i have tried that before but got some errors on this add on.. i will post print later..

Edit: When i enable add on support, i got this: https://ibb.co/v36fNzr

When i try to add episodes with the add on, i click on "select episodes", but the links don't get javascript: to stop forwarding like this video tutorial: https://www.youtube.com/watch?v=ZHCH3rNWYS8&feature=youtu.be

So, when i try to click on the episode, the page redirect me to the ep page. https://ibb.co/xXPzB1j

Sorry for post to much, that's all bugs that i found.

hama3254 commented 3 years ago

For do what you said, i need the add on for the browser, right? and enable http server on the options i think.. i have tried that before but got some errors on this add on.. i will post print later..

you don't have to for crunchyroll you can just use the overview page and add them like a normal episode : https://youtu.be/1g2-QQajZ5Y?t=24

Edit: When i enable add on support, i got this: https://ibb.co/v36fNzr

This happens if there is already something that uses the defaul http port (which is port 80) so if you let any other http server or you have more than one downloader window open it can not bind to that port.

When i try to add episodes with the add on, i click on "select episodes", but the links don't get javascript: to stop forwarding like this video tutorial: https://www.youtube.com/watch?v=ZHCH3rNWYS8&feature=youtu.be So, when i try to click on the episode, the page redirect me to the ep page. https://ibb.co/xXPzB1j

the JavaScript that changes the website to allow the selection is part of the downloader and gets importet via the http server which did not work for you so the selection also does not work (like the whole plugin itself)

kanohn commented 3 years ago

you don't have to for crunchyroll you can just use the overview page and add them like a normal episode : https://youtu.be/1g2-QQajZ5Y?t=24

Ah, got it, thanks. Now it's much faster, but you could look into the simultaneous issue if you try to download by the episodes link? like: https://www.crunchyroll.com/pt-br/naruto-shippuden/episode-1-homecoming-509768

For example, a well time to make a queue list by adding episodes one by one manually, when we go sleep and want to download more than 1 season of episodes. Naruto Shippuden have around 18 episodes for each season. With it downloading 2 episodes at a time, my notebook get much fan noise by power consuming for re-encoding 👍

This happens if there is already something that uses the defaul http port (which is port 80) so if you let any other http server or you have more than one downloader window open it can not bind to that port.

Weird, i have apache server but already changed the port to 8080 but it's on my VMWare virtual ubuntu, so i don't know what can be interfering and still can't use this feature :(

kanohn commented 3 years ago

https://ibb.co/VmkzbSZ https://ibb.co/MGXbVdJ

I don't know exactly how to reproduce, but for this method of adding animes, it happened only when i open program and don't set simultaneous download value, even if default value is 1. So i setup the value, restarted the program and don't happened more.

For the other method, it doesn't matter if set the value or not..

But it's not confirmed, tested few times.

hama3254 commented 3 years ago

The downloader keeps saved settings, it makes no difference if you set the value to 1 or it loads the value 1 from the registry. I guess the error is a "false negative" due to the way i updated the running downloads count. Now i reversed this with instead of checking each download if it's running i amuse they run and reduce the count by the finished ones, with that way it should no longer be possible to get this error.

hama3254 commented 3 years ago

the release is now here : https://github.com/hama3254/Crunchyroll-Downloader-v3.0/releases/tag/v3.7.2

kanohn commented 3 years ago

Thanks!

hama3254 commented 3 years ago

since this should be solved i close this, if there are any new issues just open a new one.

kanohn commented 3 years ago

I'm testing the new version now.. the issue persist: https://ibb.co/svPys6Q